IRC log for #koha, 2022-08-05

← Previous day | Today | Search | Index

All times shown according to UTC.

Time Nick Message
00:47 fridolin joined #koha
01:25 mtj tcohen++ congrats on the jenkins upgrade
02:07 tuxayo tcohen++
02:09 Discovery of the day: git rebase --signoff upstream/master
02:09 it will signoff every commit on top of master!
02:09 In one command! :D
02:11 fridolin tuxayo: whooooo handy
02:38 tuxayo @later tell Joubu 30847 doesn't apply (the infamous error, not even conflicts), rebase needed or at least pushing your local branch to a repo so I can use it to not get the error anymore and get instead conflicts that I'll try to solve.
02:38 huginn` tuxayo: The operation succeeded.
05:26 reiveune joined #koha
05:27 reiveune hello
05:28 paulderscheid[m] morning #koha
05:51 fridolin joined #koha
06:04 marcelr joined #koha
06:04 marcelr hi #koha
06:39 * ashimema is back
06:39 ashimema 1.2k messages in the log.. ouch
06:48 cait joined #koha
06:48 cait good morning #koha!
06:52 marcelr hi ashimema enjoyed your time off ?
06:52 hi cait
06:52 cait hi Marcel
06:53 ashimema I did indeed, it was a much needed break and tech detox
06:54 marcelr dont get too much poison on your first day :)
06:54 cait back on a Friday? what are you doing!
06:55 marcelr you know the vacation shortcut key: ctrl+A and delete
06:55 and 1.2K are gone
06:57 ashimema Haha, saves on leave days and gives me a day to work through mail and stuff rather than having to hit the day at a sprint
06:57 A few big upgrades next week
06:57 cait ok, so enjoy yor email backlog :)
06:57 ashimema Anyone care to summarize 2 weeks on Koha chatter?
06:58 cait we are here if you need to talk ;)
06:58 we decided on the lts Wednesday night
06:58 marcelr business as usual
06:58 ashimema Cool, what was the verdict?
06:58 cait but there should be an email some time
06:58 marcelr lol
06:58 ashimema Haha
06:58 cait 22.11, 1.5 years regular, 3 year lts, 1.5 year overlap
06:59 ashimema Coolios
07:01 dcook That was a fast 2 weeks...
07:02 marcelr hi dcook
07:02 wahanui hi dcook are you around?
07:02 dcook wahanui forget dcook
07:02 wahanui dcook: I forgot dcook
07:02 dcook dcook?
07:02 :D
07:03 allo marcelr
07:07 I need to stop answering emails and get oot of here...
07:07 welcome back ashimema
07:07 ciao for now...
07:08 ashimema 🙂
07:25 marcelr @Joubu still around here ?
07:25 huginn` marcelr: I've exhausted my database of quotes
07:26 Joubu yes
07:26 marcelr Joubu: the second patch on bug 27421 is a problem
07:26 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=27421 enhancement, P5 - low, ---, jonathan.druart+koha, BLOCKED , Porting tools/stage-marc-import.pl to BackgroundJob
07:26 marcelr my reconstruction is not good
07:26 linux patch doesnt do the job
07:26 Joubu yes... pushing things in the same area we are doing refactoring \o/
07:26 I will have a look in a bit
07:28 ashimema How's the background job stuff been going in my absence.. much movement?
07:28 Refactorings sound promising
07:29 Joubu rebasing them...
07:39 marcelr: reattaching, obsoleting yours. I haven't tested them yet however.
07:43 marcelr: seems ok after a quick test
07:47 marcelr great, now deep into the dates stuff
08:18 paulderscheid[m] ashimema: You survived ^^
08:18 Joubu in case I haven't shared it enough - note that this is the entry point for ERM: https://tree.taiga.io/project/[…]oha-erm/wiki/home
08:30 paulderscheid[m] Did you already decide on the release maintainer for the LTS version in the last dev meeting?
08:31 Just out of curiosity. We're very happy @LMSCloud.
08:32 Joubu happy about being the release maintainer for the LTS version?
08:32 :D
08:32 paulderscheid[m] Haha, no. ^^
08:32 Happy that there will be an LTS.
08:34 Maybe we can provide the release maintainer for the next LTS.
08:34 We'll see.
08:36 ashimema finding a maintainer will always be the hardest bit I reckon
08:37 paulderscheid[m] I'm not competent enough about koha and perl yet, or I'd jump right on it.
08:38 ashimema best way to learn is to jump 😜
08:39 paulderscheid[m] I still feel like that's too critical for someone who started working on Koha 7 months ago ^^
08:39 ashimema there are friendly people to help 😜
08:39 haha
08:39 perhaps 😜
08:39 testing and QA are great first steps
08:39 paulderscheid[m] How do you get into QA. Do you just volunteer?
08:41 cait that's about it
08:42 ashimema anyone can fail QA too
08:44 signing off things and giving constructive criticism to the UX and design, and asking questions about code choices is good
08:44 be great to see you in the next team paulderscheid
08:45 paulderscheid[m] I'd be happy.
08:45 cait exactly that, sorry, got distracted (and wouldn't be able to phrase it tht well) :)
08:46 but yeah, we got a big backlog with a little more technical sign-offs too
08:46 so starting there would be pretty awesome too
08:46 paulderscheid[m] There's a ton of bugs that revolve around 'boring' stuff that no-one wants to touch. ^^
08:47 ashimema yup
08:47 there's also a huge number of small bugs that can be picked off..
08:47 I tend to try and chug through at least a few of these daily before starting on a harder one.. just to keep the queues flowing
08:48 keeping those moving would help free up others for the scary stuff
08:48 and they're generally a good way to get up to speed
08:52 paulderscheid[m] Yeah, somehow I always end up with very complicated ones that seemed easy. ^^ But that's just experience, I guess.
08:54 cait I think it's normal
08:54 like when pulling on a thread on a knitted sweater...
08:54 ashimema haha
08:54 indeed
08:56 I tend to look at the needs signoff bugs, sorted by severity and patch complexity
08:56 'trivial patch' should be fairly trivial 😜
08:56 paulderscheid[m] That's a good tip
08:57 Joubu marcelr: looks ok for me using dd/mm/yyyy and mm/dd/yyyy
08:57 marcelr it is okay only when i use yymmdd
08:58 ashimema not everyone is good at adding those fields on bugzilla.. but they are usually fairly accurate 🙂
08:58 like, I imagine bug 31234 could be up your street paulderscheid.. it's a tiny javascript change
08:58 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31234 major, P5 - low, ---, fridolin.somers, Needs Signoff , SubfieldsToAllowForRestrictedEditing : data from drop-down menu not stored
09:00 paulderscheid[m] Cool, thanks.
09:02 marcelr please help on bug 30718
09:02 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30718 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Use flatpickr's altInput option everywhere
09:02 marcelr it applies now
09:02 please test it
09:02 see my last comments
09:02 ashimema excellent
09:02 wahanui darn tootin' it is.
09:03 Joubu marcelr: I am setting up a sandbox
09:04 marcelr: https://staff-bug30718.sandbox[…]?biblionumber=117
09:04 can you recreate the problem there?
09:04 syspref is metric
09:04 marcelr hmm Joubu i added the hold on opac
09:04 Joubu ha!
09:05 marcelr small detail hahaha
09:05 Joubu that's why steps to recrate is useful ;)
09:05 marcelr most holds are created on opac
09:05 Joubu OPAC has different JS functions...
09:05 when it's not specified I am assuming the staff client is used
09:06 marcelr how can i log in on this sandbox
09:06 Joubu OPAC explodes Invalid value passed, reserves.expirationdate=23/08/2022 expected type is date at /usr/share/perl5/Exception/Class/Base.pm line 88
09:06 koha/koha
09:07 marcelr thats reassuring to me
09:07 wasnt testing for nothing at least
09:08 Joubu hum opac has been mostly ignored from this patchset...
09:08 marcelr yeah opac is not important lol
09:08 Joubu flatpickr's options haven't been adjusted there
09:09 marcelr sounds like more work..
09:14 Joubu not much
09:19 marcelr switched back to 27421
09:22 cait put on my QA hat now too - had to catch up on mails first from my day off yesteday
09:25 marcelr Joubu: some tests may not be easy indeed, but provide great mocking opportunities
09:26 Joubu the jobs are simply calling 1 C4 subroutine...
09:26 we could mock everything and make sure the sub is called, but that's kind of pointless
09:27 marcelr i ran a few tests already while git grepping changed subs
09:27 it is the standard 'we had no tests before' thing ?
09:28 Joubu please, not to me :D
09:28 it's more "how to write useful test"
09:28 ashimema bug 27421
09:28 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=27421 enhancement, P5 - low, ---, jonathan.druart+koha, Needs Signoff , Porting tools/stage-marc-import.pl to BackgroundJob
09:28 marcelr note that i have been writing kind of pointless tests because qa insisted
09:29 Joubu see last comment. I can make you happy and write something silly, but I am really wondering how we could provide something meaningful for that kind of modules
09:29 marcelr: yes but today I am not in a mood I want to lose my time writing useless code
09:29 marcelr i understand your point but it is a very dangerous argument
09:30 i will continue interfacet testing
09:34 Progress: 1 / 0 is really strange
09:36 Joubu: my import job finished but says 1/0 but the stage job finished with 1/1
09:36 the record got in just fine
09:38 |  9 | finished |        1 |    0 |             51 | marc_import_commit_batch
09:40 Joubu hum weird, it might be coming from the callback
09:41 I had trouble with the call methods in C4::ImportBatch, they were not working
09:41 but I thought the patches fixed them
09:46 marcelr anyone willing to test bug 29144 ?
09:46 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Move branches.opac_info to AdditionalContents allowing multi language
09:51 marcelr Joubu i will be following up on those two bugs 27421 and 30718 in coming weeks but next week will probably not show much activity from me
09:51 Joubu thank you, marcelr!
09:57 ashimema marcelr
09:57 Note: You may need to set ListOwnershipUponPatronDeletion to
09:57 delete to fix a pending issue in patron->delete with lists.
09:57 is that a mistake comment in `Bug 29144: Add $contents->find_best_match, $library->opac_info`
09:57 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=29144 enhancement, P5 - low, ---, m.de.rooy, Needs Signoff , Move branches.opac_info to AdditionalContents allowing multi language
10:02 cait bbiab
10:13 fridolin left #koha
10:16 oleonard joined #koha
10:44 cait can somemone QA bug 30992? I signed off
10:44 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30992 minor, P5 - low, ---, jonathan.druart+koha, Signed Off , Hard to translate single word strings
10:45 cait same for bug 31264 please
10:45 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31264 enhancement, P5 - low, ---, jonathan.druart+koha, Signed Off , CalendarFirstDayOfWeek not taken into account when configuring curbside pickups
10:46 cait I am back on 29897
10:53 ashimema I'm on 30992 now
10:55 done and done
10:56 cait thx!
10:58 ashimema: you are too fast :) I have a small follow-up bug for 20992: bug 31272
10:58 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31272 trivial, P5 - low, ---, katrin.fischer, Needs Signoff , Show library name not code when placing item level holds in OPAC
10:58 ashimema hehe
10:58 cait written by me... :)
10:59 ashimema excellent
10:59 wahanui darn tootin' it is.
10:59 ashimema great to see bug 31162 garnering interest
10:59 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=31162 enhancement, P5 - low, ---, martin.renvoize, Signed Off , Add a clear cataloguing module home page
11:39 tcohen hola #koha
11:39 wb ashimema
11:41 hola Joubu!
11:43 claw joined #koha
11:49 mtj hi folks, ive added some TZ tests for the u18/brazil/sao_paulo bug 30030
11:49 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=30030 normal, P5 - low, ---, mtj, Needs Signoff , Test t/db_dependent/Koha/Patrons.t is_going_to_expire fails on U18
12:40 cait back on 20511
12:42 ashimema bug 20511
12:42 huginn` Bug https://bugs.koha-community.or[…]_bug.cgi?id=20511 normal, P5 - low, ---, jonathan.druart+koha, Signed Off , Seasonal prediction just in the staff language
13:13 cait hm is this a "strict SQL" bug?
13:14 C4::Serials::Numberpattern::Ad​dSubscriptionNumberpattern(): DBI Exception: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /kohadevbox/koha/serials/create-numberpattern.pl line 58
13:16 filed 31297
13:39 Dyrcona joined #koha
13:40 oleonard Is there some kind of extra setup step I need to take for plugin searches to work?
13:40 I keep getting a 500 error
13:40 ashimema hmm, shouldn't be
13:40 oleonard ...although I don't know if I see anything relevant in the logs
14:06 tcohen ashimema: should we move koha2koha and freeform to core ?
14:06 ashimema yes
14:06 tcohen ok
14:06 ashimema 🙂
14:06 I reckon so
14:07 though I also think koha2koha should gradually get converted to both sides of the ISO standard
14:07 so Koha2Koha becomes ISO both ways
14:07 tcohen there seems to be wake in interest on them, and having them as core features would (1) ease implementation and (2) allow translations and better integration
14:07 ashimema agreed
14:08 I'm losing the battle here to formalise that we switch ILL backends to proper plugins instead of the current half way house they ocupy
14:08 oleonard I was just wondering about that
14:09 (trying to play with Koha2Koha now)
14:13 tcohen in order to make koha2koha and freeform core, we need to solve the 'path' weirdness of ILL backends
14:13 i.e. there one and only one path and classes are queried on the filesystem
14:14 we need to have the 'core one' and be able to define new paths (in koha-conf, by plugin hooks, etc)
14:15 ashimema not sure I follow..
14:15 my brain isn't fully up to speed yet after a break 😛
14:19 tcohen hahaha
14:20 * ashimema is currently looking at API's for time out from his email queue
14:20 ashimema just about remembered what I was working on before I left
14:20 trusted self checkout on the OPAC via modals
14:20 tcohen Koha/Illrequest.pm:318
14:22 ashimema the way I see it what ILL backends do is just the same as Plugins.. only the structure predates it..
14:22 so I reckon most issues are already resolved at the Plugins level.. we'd just need to migrate to using plugins more formally?
14:23 as for core vs non-core.. that's a little more than my brain has in i right this second.. haha
14:23 tcohen hahaha, it's friday here too
14:23 I was wondering how not to hurt your backends
14:24 ashimema I like some of the 'capabilities' stuff that ILL has.. it might be nice to add that to plugins support
14:24 i.e. I think we should look at both area's
14:29 reiveune bye
14:29 reiveune left #koha
14:31 tcohen @later tell thd hi there! any news?
14:31 huginn` tcohen: The operation succeeded.
15:00 bag joined #koha
15:06 huginn` News from kohagit: Bug 27497: Compiled CSS <https://git.koha-community.org[…]4a9a1609ca18aeeff>
15:06 News from kohagit: Bug 30500: DBRev 22.06.00.032 <https://git.koha-community.org[…]a96237a794762e2f2>
15:06 News from kohagit: Bug 30500: (QA follow-up) Separate code execution streams for obviously independent... <https://git.koha-community.org[…]a3b2b6bcb6b82a461>
15:06 News from kohagit: Bug 31264: Curbside pickups - Take CalendarFirstDayOfWeek into account <https://git.koha-community.org[…]6efd3f94ce1429ba1>
15:06 News from kohagit: Bug 31272: Use TT plugins for pickup library and due date in opac-reserve.pl <https://git.koha-community.org[…]0bde5dcd049d88660>
15:06 News from kohagit: Bug 31249: Use cronlogaction on update_patrons_category.pl <https://git.koha-community.org[…]34a5a555a755f75a2>
15:06 News from kohagit: Bug 30992: Improve translatability for 'for' <https://git.koha-community.org[…]15a860a5f62ee05aa>
15:06 News from kohagit: Bug 30992: Improve translatability for Waiting at|On hold <https://git.koha-community.org[…]02f812ecf034433d4>
15:06 News from kohagit: Bug 30500: Allow patrons to change in transit holds pickup locations <https://git.koha-community.org[…]fcc1df33fd4644e8f>
15:06 News from kohagit: Bug 30500: Add OPACInTransitHoldPickupLocationChange syspref <https://git.koha-community.org[…]5813b7a8536382d64>
15:06 News from kohagit: Bug 27497: Display Koha version in staff interface home page <https://git.koha-community.org[…]310424f08502c8b35>
15:11 oleonard ashimema still around?
15:11 ashimema yup
15:11 anoth 40 mins
15:11 oleonard I'm curious about the choice to remove the toolbar from the new cataloging home page
15:11 ashimema haha
15:12 yeah.. me too
15:12 I'd love guidance there
15:12 or just input
15:12 it certainly needs a bit more iterating
15:13 oleonard I think the toolbar is still useful. I'd keep it and also have a "Basic editor" link under the "New" heading. I guess some people would find that redundant but redundancy doesn't bother me.
15:13 ashimema could you make that comment on the bug?
15:13 oleonard Sure
15:13 ashimema I'm happy to restore it
15:13 but would like the chaps already playing with it to see the opinion come in 🙂
15:14 it was a 'play time' project before I went on vacation really
15:15 oleonard I think it's a good idea
15:16 ashimema 🙂
15:16 glad you like the idea
15:16 out of interest.. what do you think of it compared to the circ homepage
15:17 i.e the centering vs full page width?
15:17 I'd love them to be consistent.. initially it wasn't deliberate to center mine.. It just kinda happened whilst I was playing
15:17 oleonard I'm pondering that. I think at the very least we can try to make the columns more even.
15:18 ashimema I know the new staff ui stuff touches the circ homepage too
15:18 not looked at it since I've been back.. but it sounds like that bug has progressed a fair bit 🙂
15:20 oleonard jajm has done a lot of follow-up work. I don't know how much additional testing there has been.
15:38 cait have a nice weekend all!
15:46 cait left #koha
15:58 ashimema right.. I think that's enough for today.. have a great weekend
16:06 tcohen have a great weekend ashimema!
16:42 irc joined #koha
17:19 cait joined #koha
17:50 fridolin joined #koha
17:50 fridolin yellow
17:50 kidclamp jenkins? or favorite color?
17:55 tcohen favorite song?
17:59 oleonard Favorite mustard?
18:07 tcohen rangi[m]: around?
18:11 hi #koha, there's a problem with the git server liz and I are looking after
18:11 the last batch of pushes I was supposed to do is on pause, whlst the bugs themselves are marked as pushed
18:28 cait joined #koha
18:46 tcohen Joubu: about the calendar, I get a permission denied error when using my gmail account
18:48 fridolin I like mustard
18:48 tcohen but what about yellow
18:48 heh
18:48 fridolin yellow is a reference to soap serie Netflix "Modern Family"
18:49 the gay always picks up the phone with a word looking at "hello"
18:49 like "jellow"
18:52 tcohen heh
19:05 huginn` News from kohagit: Bug 29971: Compiled CSS <https://git.koha-community.org[…]704bd7b592ca0595f>
19:05 News from kohagit: Bug 31289: Hide Article requests column in circulation rules when ArticleRequests... <https://git.koha-community.org[…]ec7727d780ba9a9af>
19:05 News from kohagit: Bug 29983: Show the column by default but hide if the feature is disabled <https://git.koha-community.org[…]36c0c8fcd8b62b1c9>
19:05 News from kohagit: Bug 29983: Format dates in templates using KohaDates (and display the time part) <https://git.koha-community.org[…]ccdd69f1f82e9b8d8>
19:05 News from kohagit: Bug 29971: Add selenium tests <https://git.koha-community.org[…]806a3de6d039d0ef2>
19:05 News from kohagit: Bug 30874: Remove category_type <https://git.koha-community.org[…]11866ea68187bd8cf>
19:05 News from kohagit: Bug 30874: Simplify categories loop construction <https://git.koha-community.org[…]eb2839dd21ff2fe07>
19:05 News from kohagit: Bug 30874: 2 more - need more investigation <https://git.koha-community.org[…]bf857c9abfc2aac33>
19:05 News from kohagit: Bug 30874: Reduce number of category fetches <https://git.koha-community.org[…]76704217ad49a8beb>
19:05 News from kohagit: Bug 30874: Replace categoryname <https://git.koha-community.org[…]eff4e7e5ae4874944>
19:05 News from kohagit: Bug 29983: Display the pretend claim column in overdue.tt <https://git.koha-community.org[…]eb75077fb5ceb27c6>
19:05 News from kohagit: Bug 29971: Remember selections across patron search pages <https://git.koha-community.org[…]e8316ffa121da7fa6>
19:08 cait joined #koha
19:09 cait joined #koha
19:43 tcohen have a great weekend y'all
19:44 git is back-ish
19:44 wajasu thx
19:44 tcohen community infrastructure is giving us some warnings
19:44 we need to talk about that on the next dev meeting
19:54 ashimema calendar tcohen
19:54 cait joined #koha
19:55 ashimema I may have access for that
20:23 cait joined #koha
20:27 cait joined #koha
20:28 cait joined #koha
20:29 cait joined #koha
20:39 cait joined #koha
21:59 wajasu ok. i think i'm going live this weekend. should i enable plugins?

← Previous day | Today | Search | Index

koha1